mhansonp commented on code in PR #7608:
URL: https://github.com/apache/geode/pull/7608#discussion_r860120568
##########
geode-cq/src/distributedTest/java/org/apache/geode/internal/cache/tier/sockets/DurableClientSimpleDUnitTest.java:
##########
@@ -139,16 +135,16 @@ public void run2() throws CacheException {
checkNumberOfClientProxies(2);
String firstProxyRegionName = null;
for (CacheClientProxy proxy : notifier.getClientProxies()) {
- assertTrue(proxy.isDurable());
- assertEquals(durableClientId, proxy.getDurableId());
- assertEquals(DistributionConfig.DEFAULT_DURABLE_CLIENT_TIMEOUT,
- proxy.getDurableTimeout());
+ assertThat(proxy.isDurable()).isTrue();
+ assertThat(durableClientId).isEqualTo(proxy.getDurableId());
+ assertThat(DistributionConfig.DEFAULT_DURABLE_CLIENT_TIMEOUT)
+ .isEqualTo(proxy.getDurableTimeout());
// Verify the two HA region names aren't the same
if (firstProxyRegionName == null) {
firstProxyRegionName = proxy.getHARegionName();
} else {
- assertTrue(!firstProxyRegionName.equals(proxy.getHARegionName()));
+
assertThat(!firstProxyRegionName.equals(proxy.getHARegionName())).isTrue();
Review Comment:
Done. Nice find. That was ugly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
