DonalEvans commented on code in PR #7627:
URL: https://github.com/apache/geode/pull/7627#discussion_r860245573
##########
geode-core/src/main/java/org/apache/geode/distributed/internal/DistributionAdvisor.java:
##########
@@ -1396,12 +1397,6 @@ boolean visit(DistributionAdvisor advisor, Profile
profile, int profileIndex, in
T aggregate);
}
- @FunctionalInterface
- protected interface Filter {
Review Comment:
Removing this class has broken the javadoc on line 1376
##########
geode-core/src/main/java/org/apache/geode/distributed/internal/DistributionAdvisor.java:
##########
@@ -1179,12 +1180,12 @@ protected void profileRemoved(Profile profile) {
/**
* All advise methods go through this method
Review Comment:
Since you're cleaning up code here, this comment does not follow Javadoc
syntax requirements (no `@return` or `@param` tags) so either those should be
added, or the comment changed to just be a regular comment rather than a
javadoc.
##########
geode-core/src/main/java/org/apache/geode/distributed/internal/DistributionAdvisor.java:
##########
@@ -1179,12 +1180,12 @@ protected void profileRemoved(Profile profile) {
/**
* All advise methods go through this method
*/
- protected Set<InternalDistributedMember> adviseFilter(Filter f) {
+ protected Set<InternalDistributedMember> adviseFilter(Predicate<Profile> f) {
Review Comment:
This change has broken the javadoc on line 1219
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
