jinmeiliao commented on code in PR #7628:
URL: https://github.com/apache/geode/pull/7628#discussion_r860303167
##########
geode-core/src/main/java/org/apache/geode/internal/cache/FilterProfile.java:
##########
@@ -1846,18 +1846,27 @@ protected void process(ClusterDistributionManager dm) {
}
CacheDistributionAdvisor cda = (CacheDistributionAdvisor)
r.getDistributionAdvisor();
- CacheDistributionAdvisor.CacheProfile cp =
- (CacheDistributionAdvisor.CacheProfile)
cda.getProfile(getSender());
- if (cp == null) { // PR accessors do not keep filter profiles around
- if (logger.isDebugEnabled()) {
- logger.debug(
- "No cache profile to update, adding filter profile message to
queue. Message :{}",
- this);
+ CacheDistributionAdvisor.CacheProfile cp;
+
+ // prevent adding the message to queue after we have processed the
queue
+ // in CreateRegionReplyProcessor.process
+ synchronized (cda) {
Review Comment:
It's synchronized on line 249 in the `CreateRegionReplyProcessor.process()`
method, the`putProfile` is a synchronized method on the `cda` object itself. So
either that finishes first or this block finishes first. The lock only needs to
be retained in the `if` block of the code where we are adding the message to
the queue, for `else` block, we don't need to retain the lock.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
