jdeppe-pivotal commented on code in PR #7600:
URL: https://github.com/apache/geode/pull/7600#discussion_r868260710
##########
buildScripts/src/main/groovy/code-analysis.gradle:
##########
@@ -15,61 +15,85 @@
* limitations under the License.
*/
-if (project.hasProperty("staticAnalysis")) {
- apply plugin: 'checkstyle'
-
- //Checkstyle configuration
- configurations.checkstyle {
- dependencies.all { dep ->
- dep.transitive = true
- }
- }
-
- //Findbugs configuration
- apply plugin: 'findbugs'
+plugins {
+// id 'com.github.spotbugs'
+ id 'jacoco'
+}
- // Switch default Findbugs report to HTML for developers
- def findbugsXmlEnabled = false
- def findbugsHtmlEnabled = true
+if (project.hasProperty("staticAnalysis")) {
- // Provide ability to change report type to XML for ingesting into other ap
- if (project.hasProperty("findbugsXmlReport")) {
- findbugsXmlEnabled = true
- findbugsHtmlEnabled = false
- }
+// //Findbugs configuration
+//
+// // Switch default Findbugs report to HTML for developers
+// def findbugsXmlEnabled = false
+// def findbugsHtmlEnabled = true
+//
+// // Provide ability to change report type to XML for ingesting into other ap
+// if (project.hasProperty("findbugsXmlReport")) {
+// findbugsXmlEnabled = true
+// findbugsHtmlEnabled = false
+// }
+//
+// configurations.findbugs {
+// dependencies.all { dep ->
+// dep.transitive = true
+// }
+// findbugs.effort = 'max'
+// findbugs.reportLevel = 'low'
+// }
+//
+// tasks.withType(FindBugs) {
+// reports {
+// xml.enabled = findbugsXmlEnabled
+// html.enabled = findbugsHtmlEnabled
+// }
+// }
+}
Review Comment:
Can this block of comments be removed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
