dschneider-pivotal commented on code in PR #7667:
URL: https://github.com/apache/geode/pull/7667#discussion_r875047289
##########
geode-core/src/main/java/org/apache/geode/internal/monitoring/executor/SuspendableExecutor.java:
##########
@@ -36,6 +36,11 @@ public void resumeMonitoring() {
suspended = false;
}
+ @Override
+ public void reportProgress() {
+ setStartTime(System.currentTimeMillis());
Review Comment:
this setStartTime should just be passed 0. SuspendableExecutor has a feature
that the thread being monitored can just set its time to 0. When the monitor
sees it as 0 will then set the actual time and see if it remains. This helps
performance by not having the thread being monitored doing a bunch of
System.currentTimeMillis calls which are rather expensive.
##########
geode-core/src/main/java/org/apache/geode/internal/monitoring/executor/AbstractExecutor.java:
##########
@@ -178,6 +178,8 @@ public void suspendMonitoring() {}
public void resumeMonitoring() {}
+ public void reportProgress() {}
Review Comment:
this one should called "setStartTime(System.currentTimeMillis());" The
non-suspendable executors need to set the start time to the current time to
report that they are still making progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
