dschneider-pivotal commented on code in PR #7705:
URL: https://github.com/apache/geode/pull/7705#discussion_r876365140
##########
geode-core/src/main/java/org/apache/geode/metrics/internal/InternalDistributedSystemMetricsService.java:
##########
@@ -227,6 +227,7 @@ private void clearAndCloseMeterRegistry() {
new HashSet<>(meterRegistry.getRegistries())
.forEach(meterRegistry::remove);
+ meterRegistry.clear();
Review Comment:
If you call clear first, then when close is called it will not be able to
ask each thing in the registry to close. If calling close on each meter is
important then you should call clear AFTER you call close,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
