jinmeiliao commented on code in PR #7697:
URL: https://github.com/apache/geode/pull/7697#discussion_r880891160
##########
geode-core/src/main/java/org/apache/geode/distributed/internal/InternalLocator.java:
##########
@@ -1043,7 +1046,15 @@ public void waitToStop() throws InterruptedException {
while (system.isConnected()) {
Thread.sleep(5000);
}
+ // there would be a gap between stoppedForReconnect being to true and
attemptingToReconnect
+ // being true, if system.waitUntilReconnected happened in between,
this method would return
+ // with "restarted" being false, so we need also to wait till system
is reconnecting
Review Comment:
`InternalLocator.attemptReconnect()` doesn't care about the return boolean,
for `GemFireCacheImpl.waitUntilReconnected()`, I am not sure how it's using the
return boolean. I need this `IDS.isReconnecting()` here specifically because
`locator.waitToStop()` as the method name indicate, can't return unless the
locator truly stops. So the call to the `IDS.waitUntilReconnected()` can't
return false, thus it needs this call there to prevent that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
