pivotal-jbarrett commented on code in PR #7211:
URL: https://github.com/apache/geode/pull/7211#discussion_r894777348
##########
geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/Put70Test.java:
##########
@@ -328,14 +325,14 @@ void
shouldSetPossibleDuplicateReturnsTrueIfNotRecoveredVersionTagAndWithPersist
@Test
void isRegionWithPersistenceReturnsTrueIfDataPolicyWithPersistence() {
- when(dataPolicy.withPersistence()).thenReturn(true);
+
when(attributes.getDataPolicy()).thenReturn(DataPolicy.PERSISTENT_REPLICATE);
assertThat(put70.isRegionWithPersistence(localRegion)).isTrue();
}
@Test
void
isRegionWithPersistenceReturnsTrueIfIsAccessorAndHavingPersistentMembers() {
- when(dataPolicy.withPersistence()).thenReturn(false);
+ when(attributes.getDataPolicy()).thenReturn(DataPolicy.PARTITION);
Review Comment:
You fill find lots of places in the old tests where the combinations of
mocks and return values used for `DataPolicy` actually created mutually
exclusive combinations but it didn't matter for the sake of the test. For the
changes here I tried to match up what the test was actually expecting for the
correct combinations that aligned to an enum value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
