agingade commented on code in PR #7211:
URL: https://github.com/apache/geode/pull/7211#discussion_r894884242
##########
geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/Put70Test.java:
##########
@@ -328,14 +325,14 @@ void
shouldSetPossibleDuplicateReturnsTrueIfNotRecoveredVersionTagAndWithPersist
@Test
void isRegionWithPersistenceReturnsTrueIfDataPolicyWithPersistence() {
- when(dataPolicy.withPersistence()).thenReturn(true);
+
when(attributes.getDataPolicy()).thenReturn(DataPolicy.PERSISTENT_REPLICATE);
assertThat(put70.isRegionWithPersistence(localRegion)).isTrue();
}
@Test
void
isRegionWithPersistenceReturnsTrueIfIsAccessorAndHavingPersistentMembers() {
- when(dataPolicy.withPersistence()).thenReturn(false);
+ when(attributes.getDataPolicy()).thenReturn(DataPolicy.PARTITION);
Review Comment:
Based on the test name; is it expecting it to treat as persistent when it is
accessor but not configured with persistence and has persistent members?
If thats the case; the change seems to be defeating the purpose by not
having:
when(dataPolicy.withPersistence()).thenReturn(false);
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
