JinwooHwang commented on code in PR #7930: URL: https://github.com/apache/geode/pull/7930#discussion_r2372015388
########## geode-core/src/integrationTest/java/org/apache/geode/distributed/internal/membership/api/CoreOnlyUsesMembershipAPIArchUnitTest.java: ########## @@ -33,11 +33,25 @@ * geode classes in a single test requires 1.5g of heap.<br> * This test class can be removed if and when we create an isolated Java module that does * not export internal membership classes. + * + * ARCHITECTURAL CHANGE NOTE: This test was updated to fix the "Layer 'api' is empty, Layer + * 'internal' is empty" + * error. The original layered architecture approach failed because membership classes were moved + * from geode-core + * to geode-membership module, leaving empty layers. The solution uses direct dependency rules + * instead of layered + * architecture to enforce the same constraint: geode-core classes should not directly access GMS + * internals. Review Comment: I agree @raboof . Let me remove it. Thank you for your advice. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
