jdaugherty commented on code in PR #14842:
URL: https://github.com/apache/grails-core/pull/14842#discussion_r2176055191
##########
grails-gradle/docs-core/src/main/template/style/guideItem.html:
##########
@@ -2,26 +2,34 @@
"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd";>
<html xmlns="http://www.w3.org/1999/xhtml"; xml:lang="en">
<head>
- <!-- Global site tag (gtag.js) - Google Analytics -->
- <script
src="/cdn-cgi/apps/head/3cOPSgo5Omz84ycX7CvigfX4cpw.js"></script><script async
src="https://www.googletagmanager.com/gtag/js?id=UA-82213539-2";></script>
Review Comment:
I had no idea that the publish guide templates would include tracking info.
I guess since we primarily use it that's ok, but several plugins also made use
of this. Should we really be exporting that? Should this be something we have
gated behind a feature flag or configuration?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
