jdaugherty commented on code in PR #14895:
URL: https://github.com/apache/grails-core/pull/14895#discussion_r2203452354
##########
gradle/java-config.gradle:
##########
@@ -27,7 +27,7 @@ extensions.configure(JavaPluginExtension) {
tasks.withType(Javadoc).configureEach { Javadoc it ->
it.options.noTimestamp true // prevent the file header with the date
- it.options.bottom "Generated ${formattedBuildDate} (UTC)"
+ it.options.bottom "Generated ${formattedBuildDateForCache} (UTC)"
Review Comment:
I think this will break our build reproducibility tests since it's no longer
based on the SOURCE_DATE_EPOCH tests. How about we change the original
formattedBuildDate to be date based instead:
formattedBuildDate = System.getenv("SOURCE_DATE_EPOCH") ?
DateTimeFormatter.ISO_INSTANT.format(buildInstant) :
DateTimeFormatter.ISO_DATE.format(LocalDate.ofInstant(buildInstant as Instant,
ZoneOffset.UTC))
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
