jdaugherty commented on PR #14903:
URL: https://github.com/apache/grails-core/pull/14903#issuecomment-3084084714
> In `Converter.java` I don't think we want to remove the `public`
modifiers, since it is a java file. This is the only java file, I found, where
this occurred.
>
> We have a mix of
>
> ```
> try {
> }
> catch (..) {
> }
> ```
>
> and
>
> ```
> try {
> } catch (..) {
> }
> ```
>
> with only some files changed in this PR. Our checkstyle config should
enforce the later based on
https://checkstyle.sourceforge.io/checks/blocks/rightcurly.html
>
> **The following may not be relevant for this PR, but I tripped over it
while looking into try/catch formatting.**
>
> The config copied from grails-forge appears to be using
com.puppycrawl.tools:checkstyle:8.33 vs 10.26.1.
https://docs.gradle.org/current/userguide/checkstyle_plugin.html
>
> And the spotless config appears to only be checking the license headers,
since we have not applied a formatter.
https://github.com/diffplug/spotless/tree/main/plugin-gradle#java
Concerning Converter.java - interfaces in java no longer suggest using
public. I was surprised by this change as well. I removed it based on the
feedback from the tools. It seems like if that's the new java recommendation,
we should go with it?
@jamesfredley @matrei do either of you have time to suggest changes to the
checkstyle config and reformat incrementally? I was hoping this could be a
joint effort =)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
