jdaugherty commented on code in PR #14942:
URL: https://github.com/apache/grails-core/pull/14942#discussion_r2247914530
##########
grails-profiles/base/profile.yml:
##########
@@ -27,15 +27,10 @@ build:
- eclipse
- idea
- org.apache.grails.gradle.grails-app
+ - groovy
Review Comment:
the grails-app plugin extends groovy. I'm not sure of the benefit of adding
that here. I'd argue it shouldn't even exist in forge if it's there.
##########
grails-profiles/rest-api/profile.yml:
##########
@@ -16,7 +16,6 @@ description: Profile for REST API applications
features:
defaults:
- hibernate5
- - events
Review Comment:
event isn't included in forge? they were split from hibernate5, so i'd have
expected them to be included. I'm not sure hibernate5 will work correctly
without it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
