jdaugherty commented on code in PR #14952:
URL: https://github.com/apache/grails-core/pull/14952#discussion_r2257747831
##########
grails-common/build.gradle:
##########
@@ -27,6 +27,8 @@ group = 'org.apache.grails.common'
dependencies {
implementation platform(project(':grails-bom'))
+ api 'org.apache.grails.gradle.common:grails-gradle-common'
Review Comment:
We still need a common inclusion point for spring and any utility classes
that rely on Spring.
* https://github.com/apache/grails-core/issues/13851 is an example that will
still cause us to deal with this problem.
* if we have to restore the annotation logic, it will go in the current
grails-common
To be clear, I am proposing:
1. rename grails-common to grails-spring-common
2. rename grails-gradle-common to grails-common
since the objection seems to be based
on the name. I also agree having gradle in the name could lead to someone
including gradle dependencies - which would be bad because they would end up on
application classpaths.
Combining these libraries will also cause a breaking change if we have to
undo this due to needing to add back the annotation readers etc. I am very
against that because it could mean having to do another release candidate and
delay 7. I would rather we split them and recombine in 8 if we determine it's
not needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
