jdaugherty commented on code in PR #5:
URL:
https://github.com/apache/incubator-grails-gradle-publish/pull/5#discussion_r2266952293
##########
plugin/src/main/groovy/org/apache/grails/gradle/publish/GrailsPublishGradlePlugin.groovy:
##########
@@ -529,15 +566,11 @@ Note: if project properties are used, the properties must
be defined prior to ap
}
protected validateProjectPublishable(Project project) {
- boolean hasJavaPlugin =
project.extensions.findByType(JavaPluginExtension)
- boolean hasJavaPlatform =
project.extensions.findByType(JavaPlatformExtension)
+ boolean hasJavaPlugin =
project.extensions.findByType(JavaPluginExtension) as JavaPlatformExtension
+ boolean hasJavaPlatform =
project.extensions.findByType(JavaPlatformExtension) as JavaPlatformExtension
Review Comment:
Tests actually fail when I make this change. I've reverted it back.
##########
plugin/src/main/groovy/org/apache/grails/gradle/publish/GrailsPublishGradlePlugin.groovy:
##########
@@ -529,15 +566,11 @@ Note: if project properties are used, the properties must
be defined prior to ap
}
protected validateProjectPublishable(Project project) {
- boolean hasJavaPlugin =
project.extensions.findByType(JavaPluginExtension)
- boolean hasJavaPlatform =
project.extensions.findByType(JavaPlatformExtension)
+ boolean hasJavaPlugin =
project.extensions.findByType(JavaPluginExtension) as JavaPlatformExtension
+ boolean hasJavaPlatform =
project.extensions.findByType(JavaPlatformExtension) as JavaPlatformExtension
Review Comment:
Tests actually fail when I make this change. I've reverted it back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
