JonasPammer opened a new pull request, #14987: URL: https://github.com/apache/grails-core/pull/14987
Close #14801 I lived under the assumption that this does not need to be as dynamic as the grails-geb/connection settings (which can be defined per Class using Annotation/Interface), and just needs to be per-project configure'able. Though that may raise the question of some user why FileDetector was made configurable in this way too - If this goes through the reason here being that it was before this. This now should also open up all other gebconfig functionality, as seen by `reportingListener` example from official geb documentation. Holding out with writing Documentation until feedback on this idea was provided. Maybe I also did something in an geb-unwanted way. <details> <summary>Unrelevant Thoughts</summary> I had originally tried to allow the use of normal Drivers and then extracting their capabilities, but as far as I was able to jungle through this is not possible. One option there would've been to intercept e.g. ChromeOptions construction when calling closure, or another hacking interception way, but i chose not to. I also had the idea to introduce a new GebConfig key, like other *-geb extensions do (e.g. grailsGeb, ). _Also I may possibly currently be trying to make a diagram to better wrap my head around grails-geb's moving parts and necessities for future encounters._ </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
