jdaugherty commented on code in PR #14999:
URL: https://github.com/apache/grails-core/pull/14999#discussion_r2288772715
##########
dependencies.gradle:
##########
@@ -22,25 +22,25 @@
// These files are split to facilitate separation of build vs application
dependencies. These are the application dependencies.
ext {
gradleBomDependencyVersions = [
- 'ant.version' : '1.10.15',
- 'asciidoctor-gradle-jvm.version' : '4.0.4',
- 'asciidoctorj.version' : '3.0.0',
- 'asset-pipeline-gradle.version' : '5.0.14',
- 'byte-buddy.version' : '1.17.6',
- 'commons-text.version' : '1.13.1',
- 'directory-watcher.version' : '0.19.1',
- 'gradle-spock.version' : '2.3-groovy-3.0',
- 'grails-publish-plugin.version' : '7.0.0-SNAPSHOT',
- 'grails-gdoc-engine.version' : '1.0.1',
- 'jansi.version' : '1.18',
- 'javaparser-core.version' : '3.27.0',
- 'jline.version' : '2.14.6',
- 'jna.version' : '5.17.0',
- 'jquery.version' : '3.7.1',
- 'objenesis.version' : '3.4',
- 'gradle-spock.version' : '2.3-groovy-3.0',
- 'spring-boot.version' : '3.5.4',
- 'springloaded.version' : '1.2.8.RELEASE',
+ 'ant.version' : '1.10.15',
+ 'asciidoctor-gradle-jvm.version': '4.0.4',
+ 'asciidoctorj.version' : '3.0.0',
+ 'asset-pipeline-gradle.version' : '5.0.15',
Review Comment:
I intentionally did not add it to the gradle bom because it would then add
conflicting dependencies that could cause issues for Gradle. It's the same
reason we have a gradle bom & grails bom.
For the asset plugin, I thought only the gradle plugin gets put on the
gradle build classpath. Am I wrong in that assumption? I don't see a benefit
of adding the other libraries for that reason.I also don't think the gradle
plugin ever should be included on the application classpath, so i don't think
we want to mix these.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
