matrei commented on code in PR #15040:
URL: https://github.com/apache/grails-core/pull/15040#discussion_r2317874839
##########
grails-forge/grails-forge-cli/src/test/groovy/org/grails/forge/cli/CommandSpec.groovy:
##########
@@ -70,6 +70,7 @@ class CommandSpec extends Specification {
String[] args = builder.toString().split(' ')
ProcessBuilder pb = new ProcessBuilder(args)
pb.environment().put('JAVA_HOME', System.getenv('JAVA_HOME') ?:
System.getProperty('java.home'))
+ pb.environment().put('GRAILS_REPO_URL',
System.getenv('GRAILS_REPO_URL') ?: null)
Review Comment:
From
https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/lang/ProcessBuilder.html#environment():
The returned map does not permit null keys or values. Attempting to insert
or query the presence of a null key or value will throw a NullPointerException.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
