jdaugherty opened a new pull request, #15052: URL: https://github.com/apache/grails-core/pull/15052
@matrei had a ClassNotFoundException thrown when testing the 7.0.0-RC2 wrapper locally. Upon researching the problem, the cause was he had an old snapshot version under the directory we download grails releases to. The reason this was a problem is we were returning snapshot builds as eligible & the wrapper assumes snapshots are more up to date than a release. This line is the problem: https://github.com/apache/grails-core/blob/2cb067e0176f86bc40a17375523b5eb52503a6d3/grails-wrapper/src/main/java/grails/init/Start.java#L151 That code should only return release types later than the version of the packaged wrapper: return new LinkedHashSet<>(myVersion.releaseType.upTo()); I wanted to add test coverage to the wrapper though, so I've refactored the helper methods for preferred version & allowed types to make this easier to test. The test "allowed release types - no preferred version - non-development for non-release" makes sure this issue doesn't happen in the future. With the refactoring, the jar size is 30KB, which is still smaller than the gradle wrapper size (44KB) so I'm considering the extra classes as an acceptable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
