jdaugherty commented on code in PR #15070:
URL: https://github.com/apache/grails-core/pull/15070#discussion_r2352531865
##########
grails-scaffolding/src/main/groovy/grails/plugin/scaffolding/GormService.groovy:
##########
@@ -46,19 +46,15 @@ class GormService<T extends GormEntity<T>> {
resourceName = GrailsNameUtils.getPropertyName(resource)
}
- protected T queryForResource(Serializable id) {
- resource.get(id)
- }
-
T get(Serializable id) {
- queryForResource(id)
+ resource.get(id)
}
List<T> list(Map args) {
resource.list(args)
}
- Long count() {
+ Long count(Map args) {
Review Comment:
This parameter addition seems unused? It doesn't look like there's a count
method on domains that takes an argument.
##########
grails-scaffolding/src/main/groovy/grails/plugin/scaffolding/RestfulServiceController.groovy:
##########
@@ -49,8 +50,9 @@ class RestfulServiceController<T extends GormEntity<T>>
extends RestfulControlle
}
@Override
+ @CompileDynamic
Review Comment:
Why is this necessary?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
