JonasPammer commented on code in PR #15067:
URL: https://github.com/apache/grails-core/pull/15067#discussion_r2364885621
##########
grails-geb/src/testFixtures/groovy/grails/plugin/geb/WebDriverContainerHolder.groovy:
##########
@@ -243,6 +244,9 @@ class WebDriverContainerHolder {
browser.driver.manage().timeouts().pageLoadTimeout(Duration.ofSeconds(settings.pageLoadTimeout))
if (settings.scriptTimeout != DEFAULT_TIMEOUT_SCRIPT)
browser.driver.manage().timeouts().scriptTimeout(Duration.ofSeconds(settings.scriptTimeout))
+ if (settings.atCheckWaiting != DEFAULT_AT_CHECK_WAITING) {
Review Comment:
to be honest, now that we read GebConfig like normal Browser instantiaton, I
don't even know if we should keep our GebConfig'able browser/driver settings
as part of our custom GrailsGebSettings (this includes for example timeouts).
i.e. rather than cc17f14a48eebd897116408c371a94300e943c94
```
env:
# Make Geb tests more resilient in slow CI environments
JAVA_TOOL_OPTIONS: -Dgrails.geb.atCheckWaiting=true
```
do
`grails-test-examples/geb-gebconfig/src/integration-test/resources/GebConfig.groovy`
```groovy
atCheckWaiting = System.getenv('CI') != null
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
