jdaugherty commented on code in PR #15335:
URL: https://github.com/apache/grails-core/pull/15335#discussion_r2725772142
##########
.github/workflows/gradle.yml:
##########
@@ -91,7 +100,6 @@ jobs:
run: >
./gradlew build :grails-shell-cli:installDist groovydoc
--continue
- --rerun-tasks
Review Comment:
This rerun has cause issues in the functional tests b/c of our transitive
dependencies. I'm fine doing it for the regular build, but we need to
introduce a build that doesn't have caching if we do this. I'd suggest just
running it weekly.
##########
.github/workflows/gradle.yml:
##########
@@ -243,10 +251,10 @@ jobs:
env:
GITHUB_MAVEN_PASSWORD: ${{ secrets.GITHUB_TOKEN }}
run: >
- ./gradlew bootJar cleanTest check
+ ./gradlew bootJar check
--continue
- --rerun-tasks
Review Comment:
Same AST transform issue / rerun issues.
##########
.github/workflows/gradle.yml:
##########
@@ -176,8 +184,8 @@ jobs:
run: >
./gradlew bootJar check
--continue
- --rerun-tasks
--stacktrace
+ --configuration-cache-problems=warn
Review Comment:
Same as core, I think if the tasks don't rerun then it's going to not
rebuild with our AST transforms sometimes, which will cause the tests to
execute with the old code.
##########
.github/workflows/gradle.yml:
##########
@@ -210,10 +218,10 @@ jobs:
env:
GITHUB_MAVEN_PASSWORD: ${{ secrets.GITHUB_TOKEN }}
run: >
- ./gradlew bootJar cleanTest check
+ ./gradlew bootJar check
--continue
- --rerun-tasks
Review Comment:
Same AST transform issue / rerun issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
