jamesfredley commented on code in PR #15411: URL: https://github.com/apache/grails-core/pull/15411#discussion_r2835697018
########## grails-test-examples/micronaut/src/integration-test/groovy/micronaut/MicronautDeclarativeClientSpec.groovy: ########## @@ -0,0 +1,61 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package micronaut + +import grails.testing.mixin.integration.Integration +import io.micronaut.context.ApplicationContext as MicronautApplicationContext +import io.micronaut.http.HttpResponse +import io.micronaut.http.client.HttpClient +import micronaut.client.MicronautTestClient +import org.springframework.beans.factory.annotation.Autowired +import org.springframework.beans.factory.annotation.Value +import spock.lang.Specification + +@Integration +class MicronautDeclarativeClientSpec extends Specification { + + @Autowired + MicronautApplicationContext micronautContext + + @Value('${local.server.port}') + Integer serverPort + + void "declarative @Client interface is registered as a bean in Micronaut context"() { + when: "looking up the declarative client bean" + def client = micronautContext.getBean(MicronautTestClient) + + then: "the bean is found and implements the interface" + client != null + client instanceof MicronautTestClient + } + + void "Micronaut HttpClient can reach the running Grails application"() { + given: "a Micronaut HTTP client targeting the running server" + def client = HttpClient.create("http://localhost:$serverPort".toURL()) Review Comment: Done in 6b59b6f. Expanded the declarative client test significantly with ersatz mocking every response scenario: **MicronautDeclarativeClientSpec** (10 tests) - direct @Client -> ersatz: - GET, POST, PUT, DELETE with mock responses - Path variable resolution - 404 and 500 error handling - Accept header via low-level HttpClient **MicronautErsatzRoundtripSpec** (17 tests) - full HTTP roundtrip through Grails: - HTTP client -> Grails controller -> service -> @Client -> ersatz for all CRUD ops - Error propagation from ersatz through the entire stack - Sequential calls to multiple ersatz-mocked endpoints - Custom response headers, empty bodies, large JSON responses (50 items) Also added the plugin @Singleton scenario @sbglasius suggested - see MicronautPluginBeanSpec (5 tests). ########## grails-forge/grails-forge-core/src/main/java/org/grails/forge/feature/build/gradle/templates/buildGradle.rocker.raw: ########## @@ -107,6 +107,17 @@ bootRun { } +@if (features.contains("grails-micronaut")) { +tasks.named('bootJar') { + loaderImplementation = org.springframework.boot.loader.tools.LoaderImplementation.CLASSIC +} + +tasks.named('bootWar') { + loaderImplementation = org.springframework.boot.loader.tools.LoaderImplementation.CLASSIC +} + +} + Review Comment: Removed in 6b59b6f per @jdaugherty's confirmation - the plugin handles it now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
