jdaugherty commented on code in PR #15420:
URL: https://github.com/apache/grails-core/pull/15420#discussion_r2835766543
##########
build-logic/plugins/src/main/groovy/org/apache/grails/buildsrc/GroovydocEnhancerExtension.groovy:
##########
@@ -89,7 +89,7 @@ class GroovydocEnhancerExtension {
@Inject
GroovydocEnhancerExtension(ObjectFactory objects, Project project) {
javaVersion = objects.property(String).convention(
- "JAVA_${GradleUtils.findProperty(project, 'javaVersion') ?:
'17'}" as String
+ project.provider { "JAVA_${GradleUtils.findProperty(project,
'javaVersion') ?: '17'}" as String }
Review Comment:
The end grails app? This is for our applications and we define
`javaVersion` in the grade.properties - which is copied to every project in
this build. This comment doesn't make sense to me. If it's not copied, we have
a bug that's why we should leave it with no default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
