Copilot commented on code in PR #15429: URL: https://github.com/apache/grails-core/pull/15429#discussion_r2836197699
########## grails-datamapping-tck/src/main/groovy/org/apache/grails/data/testing/tck/domains/DataServiceRoutingProduct.groovy: ########## @@ -0,0 +1,39 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.grails.data.testing.tck.domains + +import grails.gorm.annotation.Entity +import org.grails.datastore.gorm.GormEntity + +@Entity +class DataServiceRoutingProduct implements GormEntity<DataServiceRoutingProduct> { + + Long id + Long version + String name + Integer amount + + static mapping = { + datasource 'ALL' + } + + static constraints = { + name blank: false Review Comment: The amount field lacks a nullable constraint, while the similar WhereRoutingItem domain class (used in WhereQueryConnectionRoutingSpec) has 'amount nullable: false'. For consistency and to prevent potential null-related issues, consider adding 'amount nullable: false' to the constraints block. ```suggestion name blank: false amount nullable: false ``` ########## grails-datamapping-tck/src/main/groovy/org/apache/grails/data/testing/tck/tests/DataServiceConnectionRoutingSpec.groovy: ########## @@ -0,0 +1,292 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.grails.data.testing.tck.tests + +import spock.lang.Issue +import spock.lang.Requires + +import org.grails.datastore.gorm.GormEnhancer + +import org.apache.grails.data.testing.tck.base.GrailsDataTckSpec +import org.apache.grails.data.testing.tck.domains.DataServiceRoutingProduct +import org.apache.grails.data.testing.tck.domains.DataServiceRoutingProductDataService +import org.apache.grails.data.testing.tck.domains.DataServiceRoutingProductService + +@Issue('https://github.com/apache/grails-core/issues/15394') Review Comment: The `@Issue` annotation references issue #15394, which is about "stabilize flaky scaffolding Geb tests" (as shown in the PR metadata). However, this test spec is testing the Data Service connection routing fix. Based on the PR description, this should reference the issue that PR #15395 was fixing. If no separate issue exists for the Data Service connection routing bug, consider either creating one or removing this annotation, since it currently points to an unrelated issue. ```suggestion ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
