jamesfredley commented on PR #15441: URL: https://github.com/apache/grails-core/pull/15441#issuecomment-3948446491
Addressed both Copilot review comments in commit 303415c: **DeepValidateWithSaveSpec** (comment on line 54): Fixed. The spec now installs a `CascadingValidator` mock via `manager.session.mappingContext.addEntityValidator()` and asserts that `mockValidator.validate(entity, _, true/false)` is called with the correct `cascade` argument on each `save()` — the same public-API pattern already used in `ValidationSpec.groovy`. **ValidationSpec** (comment on line 40): Confirmed — `AbstractMappingContext.addEntityValidator(entity, null)` is indeed a no-op (guarded by `validator != null`). However, `ValidationSpec.groovy` lives in `grails-data-neo4j`, which the module README explicitly states is not included in the Grails 7 build. This is a pre-existing issue outside the scope of this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
