jamesfredley commented on code in PR #15425:
URL: https://github.com/apache/grails-core/pull/15425#discussion_r2849264330
##########
grails-data-hibernate5/grails-plugin/src/main/groovy/org/grails/plugin/hibernate/support/GrailsOpenSessionInViewInterceptor.java:
##########
@@ -123,26 +123,40 @@ public void postHandle(WebRequest request, ModelMap
model) throws DataAccessExce
}
}
+ RuntimeException firstFlushException = null;
for (AdditionalSessionFactoryConfig config :
additionalSessionFactories) {
SessionFactory sf = config.sessionFactory;
SessionHolder additionalHolder = (SessionHolder)
TransactionSynchronizationManager.getResource(sf);
if (additionalHolder != null) {
Session additionalSession = additionalHolder.getSession();
try {
- FlushMode additionalFlushMode =
additionalSession.getHibernateFlushMode();
- boolean additionalIsNotManual = additionalFlushMode !=
FlushMode.MANUAL && additionalFlushMode != FlushMode.COMMIT;
- if (additionalIsNotManual) {
- if (logger.isDebugEnabled()) {
- logger.debug("Eagerly flushing additional
Hibernate session for datasource '" + config.connectionName + "'");
+ try {
+ FlushMode additionalFlushMode =
additionalSession.getHibernateFlushMode();
+ boolean additionalIsNotManual = additionalFlushMode !=
FlushMode.MANUAL && additionalFlushMode != FlushMode.COMMIT;
+ if (additionalIsNotManual) {
+ if (logger.isDebugEnabled()) {
+ logger.debug("Eagerly flushing additional
Hibernate session for datasource '" + config.connectionName + "'");
+ }
+ additionalSession.flush();
+ }
+ }
+ catch (RuntimeException ex) {
+ if (firstFlushException == null) {
Review Comment:
Added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
