jdaugherty commented on code in PR #15420:
URL: https://github.com/apache/grails-core/pull/15420#discussion_r2853420114
##########
build-logic/plugins/src/main/groovy/org/apache/grails/buildsrc/GroovydocEnhancerExtension.groovy:
##########
@@ -89,7 +89,7 @@ class GroovydocEnhancerExtension {
@Inject
GroovydocEnhancerExtension(ObjectFactory objects, Project project) {
javaVersion = objects.property(String).convention(
- "JAVA_${GradleUtils.findProperty(project, 'javaVersion') ?:
'17'}" as String
+ project.provider { "JAVA_${GradleUtils.findProperty(project,
'javaVersion') ?: '17'}" as String }
Review Comment:
@jamesfredley this is my only last concern - again to force failures b/c we
don't want core to be misconfigured. Can we remove this default & merge this
PR? We can then re-address any extraction separately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
