jprinet commented on PR #15483:
URL: https://github.com/apache/grails-core/pull/15483#issuecomment-4006003900

   Just a disclaimer, I am not familiar with the codebase and just looked for a 
minimal changeset to fix the cache misses 😛
   
   To your question @jdaugherty 
   1. this is happening on test tasks, you can identify the 19 culprits 
[there](https://ge.solutions-team.gradle.com/c/yurlk5t7wunlc/nngl4lil4cbyo/task-inputs?cacheability=cacheable,overlapping-outputs,validation-failure&task-text=systemProperties)
   2. I will give a try to moving the normalization in there (can't do before 
next week though)
   
   Related to 2., I also noticed [21 cache 
misses](https://ge.solutions-team.gradle.com/c/yurlk5t7wunlc/nngl4lil4cbyo/task-inputs?cacheability=cacheable,overlapping-outputs,validation-failure&task-text=asset)
 on `AssetForkedCompileTask` (coming from 
[asset-pipeline](https://github.com/wondrify/asset-pipeline) plugin)
   They are also due to the `sbom.json` being different in the Jar files from 
the `classpath` / `assetClassPath`
   
   An opportunistic fix could be to make the `assetClassPath` input use the 
`RuntimeClasspath` normalization instead of a `RelativePath` one 
[there](https://github.com/wondrify/asset-pipeline/blob/cda9a75457718b68d25b0acba0ef13f7f8be05ea/asset-pipeline-gradle/src/main/groovy/asset/pipeline/gradle/AssetForkedCompileTask.groovy#L52)
 (mentioning as I found you being the latest contributor 😙)
   
   Fixing the `CycloneDxPlugin` to generate deterministic `sbom.json` would 
probably be a better idea if at all possible


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to