matrei commented on PR #15505: URL: https://github.com/apache/grails-core/pull/15505#issuecomment-4083964506
> I also noticed you removed the usage of enums - specifically HttpStatus. Generally, I'm a fan of test code not referencing enum values so the test breaks if there is a change. With that said, I'm not sure the HttpStatus values will ever change. Spring has an equivalent & we could use it instead. I'm somewhat indifferent here, but thought I'd put this out there in case we should discuss further. I think that if Enums (or Constants) are not providing any value, but rather detracts from readability, we should not use them in tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
