jamesfredley commented on code in PR #15522:
URL: https://github.com/apache/grails-core/pull/15522#discussion_r2969979440
##########
grails-web-url-mappings/src/main/groovy/org/grails/web/mapping/RegexUrlMapping.java:
##########
@@ -253,8 +253,8 @@ protected Pattern convertToRegex(String url) {
// For /(*)?+(\.(*))? we want regex: /(.+?)?(?:\.([^/.]+))?
(optional, greedy)
// Only apply greedy regex if this logical URL actually
includes the greedy token
String processed = urlEnd
Review Comment:
Nit: these comments still reference the old regex (`.+?`). Now that the
pattern is `[^/]+?`, the comments should be updated to match:
```java
// For /(*)+(\.(*))? we want regex: /([^/]+?)(?:\.([^/.]+))? (required,
greedy)
// For /(*)?+(\.(*))? we want regex: /([^/]+?)?(?:\.([^/.]+))? (optional,
greedy)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
