borinquenkid commented on PR #15530:
URL: https://github.com/apache/grails-core/pull/15530#issuecomment-4181546058

   
   
   > merge() return value: The change from returning the original object to 
returning the
   > merged instance is a semantic change. Apps that call merge() but continue 
using the
   > original reference may silently work with stale data.
   This was an overlook of my part. I perserved the 
`HibernateGormInstanceApi.save` behavior by implementing an upsert.
   
   > DetachedCriteria.list() with args: Returning PagedResultList for any 
non-empty
   > args (not just when max is set) could change behavior for code that passes 
sort-only
   > arguments.
   
   That could be adjusted.
   
   > Spring ORM fork maintenance: The forked HibernateTransactionManager and 
related
   > classes will need ongoing maintenance as they diverge from Spring's 
JPA-based approach.
   > Security patches in Spring's transaction management won't automatically 
flow to the fork.
   I can write a thin wrapper that delegates functions 
   
   Can we just get call the Milestone and call it limitations?
   There is no reason to change behavior for these.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to