jdaugherty commented on code in PR #15578: URL: https://github.com/apache/grails-core/pull/15578#discussion_r3089522638
########## .github/PULL_REQUEST_TEMPLATE.md: ########## @@ -0,0 +1,68 @@ +<!-- +SPDX-License-Identifier: Apache-2.0 + +Licensed under the Apache License, Version 2.0 (the "License"); +you may not use this file except in compliance with the License. +You may obtain a copy of the License at + + https://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, software +distributed under the License is distributed on an "AS IS" BASIS, +WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +See the License for the specific language governing permissions and +limitations under the License. +--> + +## Description +<!-- Describe your change and the problem it solves. Link to the related issue(s) if they exist. --> + +## Contributor Checklist + +Please review the following checklist before submitting your pull request. Pull requests that do not meet these requirements may be closed without review. + +### Issue and Scope + +- [ ] This PR is linked to an existing issue that has been **acknowledged or approved** by the project team. + If no approved issue exists, please give background on why this change is necessary. Tickets are preferred for release change log history. +- [ ] This PR addresses the **complete scope** of the linked issue. Partial implementations or unfinished + work should not be submitted for review. +- [ ] This PR contains a **single, focused change**. Unrelated changes should be submitted as separate pull requests. +- [ ] This PR targets the **correct branch** for the type of change: + - **Patch release branches** (e.g., `7.0.x`): Bug fixes only. No new features or API changes. + - **Minor release branches** (e.g., `7.1.x`): New features are welcome, but must avoid breaking existing APIs. + - **Major release branches** (e.g., `8.0.x`): Reserved for major changes. Breaking API changes are permitted. + +### Code Quality + +- [ ] I have **added or updated tests** that cover the changes introduced in this PR. + All code contributions are expected to include appropriate test coverage. +- [ ] I have verified that all existing tests pass by running `./gradlew build --rerun-tasks`. +- [ ] My code follows the project's **code style** guidelines. I have run `./gradlew codeStyle` and resolved + any violations. See [Code Style](../CONTRIBUTING.md#code-style) for details. +- [ ] This PR does **not** include mass reformatting, style-only changes, or large-scale refactoring unless + it was **explicitly approved** in the linked issue. Unsolicited reformatting will not be accepted. Review Comment: We need to add a line about using a good AI model and what we find works best. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
