jamesfredley commented on PR #15367:
URL: https://github.com/apache/grails-core/pull/15367#issuecomment-4263077165
## End-to-End CLI / Console Build + Smoke Test Results
Branch tested: pr-15367 @ `9f923a4014` (Address PR review feedback for JLine
3 / Jansi 2 upgrade)
Env: Windows 11, JDK 21.0.9 (Corretto), Gradle 8.14.4
### Tests - ALL PASSED
| Module | Result |
|---|---|
| `grails-bootstrap` | 192/192 (3 skipped) |
| `grails-shell-cli` | 102/102 (2 skipped) |
| `grails-console` | 28/28 |
| `grails-gradle-model` (nested build) | All passed (CommandLineParserSpec +
EnvironmentTests) |
### Builds - ALL SUCCEEDED
| Artifact | Task | Output |
|---|---|---|
| grails-core (all modules) | `publishToMavenLocal` |
`org.apache.grails:*:8.0.0-SNAPSHOT` in `~/.m2` |
| grails-gradle (plugins + bom + model) | `publishToMavenLocal` | Plugin
markers + BOM |
| grails-shell-cli | `installDist` |
`grails-shell-cli/bin/grails-shell-cli{,.bat}` |
| grails-wrapper | `installDist` |
`apache-grails-wrapper-bin/grailsw{,.bat}` |
| grails-forge `:grails-cli` (meta) | `installDist` |
`apache-grails-bin/bin/{grails,grails-forge-cli,grails-shell-cli}` |
| grails-forge `:grails-cli:shadowJar` | `publishToMavenLocal` |
`grails-cli-8.0.0-SNAPSHOT-all.jar` |
| grails-forge `:grails-forge-cli` | `build` | PicoCLI jar |
| grails-forge `:grails-forge-web-netty` | `build` | Netty web backend jar |
### Smoke Tests - ALL PASSED (exit 0)
| Binary | Command | Result |
|---|---|---|
| `grails-shell-cli.bat` | `--help` | Shows commands list |
| `grails-shell-cli.bat` | `list-profiles` | Shows 7 profiles |
| `grails-shell-cli.bat` | `profile-info web` | Shows web profile details |
| `grails-shell-cli.bat` | interactive (stdin piped) | JLine 3 starts,
`grails>` prompt rendered |
| `grails.bat` (meta) | `--help` | Works |
| `grails.bat` (meta) | `-t forge --help` | Delegates to forge-cli |
| `grails.bat` (meta) | `-t shell help` | Delegates to shell-cli |
| `grails-forge-cli.bat` | `--help` | PicoCLI usage |
### JLine 3 Runtime Verification
`org.jline.utils.Log logr` in output confirms JLine 3.x classes are loaded.
The non-TTY fallback "Unable to create a system terminal, creating a dumb
terminal" path functions correctly when stdin is not a real terminal (batch /
piped execution).
### Notes
- `grailsw.bat` (outside a Grails project) surfaces a pre-existing BOM
resolution quirk: `GrailsVersion.getPreferredGrailsVersion` early-returns when
a `gradle.properties` without a `grailsVersion` key is present, bypassing the
`PREFERRED_GRAILS_VERSION` env var. This is unrelated to the JLine / Jansi
upgrade and not introduced by this PR.
### Verdict
PR is functionally correct. All CLIs and consoles build and run with JLine 3
/ Jansi 2. No regressions detected.
Assisted-by: claude-code:claude-opus-4-7
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
