bito-code-review[bot] commented on PR #15583: URL: https://github.com/apache/grails-core/pull/15583#issuecomment-4274185291
<!-- Bito Reply --> Yes, to maintain consistency between save and query paths, the query conversion should also fall back to the original String when ObjectId conversion fails for invalid hex. Currently, the IdentityEncoder falls back gracefully, but IdEquals in MongoQuery directly calls convert() without try-catch, which could throw an exception. Wrapping it in try-catch like the coerce methods would align the behavior. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
