vigneshsiva11 commented on issue #15377: URL: https://github.com/apache/grails-core/issues/15377#issuecomment-4294439199
Hi @jamesfredley and maintainers Thanks for explaining the options. I want to help fix this issue and discuss my approach before creating a request. I think Option 1, Gradle Feature Variant, is the long-term solution for Grails 8. This option does not break existing code, so users of "grails-data-hibernate5-dbmigration" do not need to change anything. It also follows Gradle practices for separating optional features. Option 1 has benefits. It does not require users to make changes to their code. Unlike Option 2, users do not need to manage "compileOnlyApi" dependencies. The plugin handles the separation cleanly. Also, CLI tooling is opt-in, ensuring that WAR deployments are clean by default. Here is my proposal: * I will create a request to fix the issue in the "grails-data-hibernate5-dbmigration" plugin. I will register a "cli" feature variant. Move the "grails-shell" dependency under that variant. This ensures that "grails-shell" and related components are not included in WAR deployments. I will test this with a WAR deployment to confirm it works. * I will create another request to update the documentation and app templates. After the plugin fix, users need guidance on how to use CLI functionality during development without affecting WAR packaging. This pull request will update the documentation to explain the developmentOnly` capability pattern. Before I start I have a questions: * Is Option 1 the direction for Grails 8? * Should the "grails-shell' split be handled at the "grails-module level," or is fixing it in "grails-data-hibernate5-dbmigration" enough? * Are there existing integration tests for WAR deployment scenarios that I should extend? * For documentation updates is there a repository I should target? I'm ready to start once we agree on the direction. Thanks again, for explaining the issue -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
