jdaugherty commented on code in PR #15327:
URL: https://github.com/apache/grails-core/pull/15327#discussion_r3123979256
##########
gradle/docs-dependencies.gradle:
##########
@@ -31,16 +31,10 @@ dependencies {
}
String resolveProjectVersion(String artifact) {
- String version = configurations.runtimeClasspath
- .resolvedConfiguration
- .resolvedArtifacts
- .find {
- it.moduleVersion.id.name == artifact
- }?.moduleVersion?.id?.version
- if (!version) {
- return null
+ def component =
configurations.runtimeClasspath.incoming.resolutionResult.allComponents.find {
Review Comment:
Are these changes necessary?
##########
grails-doc/build.gradle:
##########
@@ -278,7 +284,7 @@ createReleaseDropdownTask.configure {
def docsTask = tasks.register('docs', Sync)
docsTask.configure { Sync it ->
- it.dependsOn(combinedGroovydoc, createReleaseDropdownTask,
':grails-data-docs-stage:docs')
+ it.dependsOn(combinedGroovydoc, auditGroovydocLinks,
createReleaseDropdownTask, ':grails-data-docs-stage:docs')
Review Comment:
The audit should be a task we run, but it shouldn't be run by default unless
we're going to capture it in the workflow summary of the build.
##########
TEST_FAILURES.md:
##########
@@ -0,0 +1,25 @@
+# Test Failures Summary
Review Comment:
What generated this? Let's remove it from being checked in.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
