The GitHub Actions job "CI - Groovy Joint Validation Build" on 
grails-core.git/migrate-grails-data-graphql-to-grails-7.1.x has succeeded.
Run started by GitHub user jamesfredley (triggered by jamesfredley).

Head commit for run:
d695a961523dca6dee9a501665af84fa1451d1f5 / James Fredley 
<[email protected]>
refactor(grails-data-graphql): address review feedback

Addresses review comments from PR #15587:

* README.md: replace ad-hoc layout with the canonical doc/api links
  used by sibling data plugins (mongodb-style), pointing at
  grails.apache.org/docs/{latest,snapshot}/grails-data/graphql/manual/.
* GormGraphqlGrailsPlugin: drop legacy authors/developers fields per
  the project policy (these belong in the publish gradle); fix the stale
  documentation URL; switch to the description/organization/scm shape
  used by MongodbGrailsPlugin.
* GrailsGraphQLConfiguration: inject the existing
  DataBindingConfigurationProperties bean to source default
  dateFormats / dateParsingLenient instead of duplicating the list.
* plugin/build.gradle:
  - drop the redundant micronaut-http-client api dep (transitively
    pulled in by micronaut-rxjava2-http-client);
  - scope rxjava2-http-client to compileOnly so the GraphQLSpec test
    trait still compiles but the dep is not exposed on consumers'
    runtime classpath (test deps must not leak into production post
    Grails 7) - the example apps already declare it themselves;
  - drop the cglib-bridge comment;
  - document why bootRun/bootTestRun are disabled (it's a plugin, not
    an app);
  - replace the inline useJUnitPlatform() with the shared
    gradle/test-config.gradle include used by the rest of the build.
* core/build.gradle: same test-config.gradle include for consistency.
* grails-test-examples/graphql/{grails-test-app,grails-docs-app,
  grails-tenant-app,grails-multi-datastore-app}/build.gradle:
  - migrate from the mixed plugins{} + apply plugin: form to a single
    plugins{} block (matches grails-test-examples/hibernate5/* and the
    spring-boot-app);
  - drop the bootRun {} block - the plugin defaults are sufficient;
  - replace `project(':grails-data-graphql')` with the published
    coord `org.apache.grails:grails-data-graphql` (test apps must not
    use project refs other than :grails-bom).
* spring-boot-app/build.gradle: replace remaining project() refs
  (:grails-data-hibernate5-{spring-boot,core}, :grails-datamapping-core,
  :grails-data-graphql-core) with their published Maven coordinates.
* PostIntegrationSpec: parse `dateCreated`/`lastUpdated` with
  java.time.Instant.parse so the spec is agnostic to whether the
  ISO-8601 response carries millisecond precision (handles both
  `...Z` and `....SSSZ` forms cleanly).
* HibernatePersistentGraphQLPropertySpec: drop the speculative
  comment about the GORM ordering shift; the new expected values
  (5/6 instead of 6/7) are simply what the integrated build produces.

Verified locally:
- :grails-data-graphql-core:test
- :grails-data-graphql:test
- :grails-data-graphql-core:codeStyle
- :grails-data-graphql:codeStyle
- :grails-test-examples-graphql-*:test (all 5 apps)
- :grails-test-examples-graphql-*:integrationTest (all 4 grails apps)

Assisted-by: claude-code:claude-opus-4.6

Report URL: https://github.com/apache/grails-core/actions/runs/24968821112

With regards,
GitHub Actions via GitBox

Reply via email to