The GitHub Actions job "CI - Groovy Joint Validation Build" on 
grails-core.git/fix/flaky-date-picker-minute-precision has failed.
Run started by GitHub user jamesfredley (triggered by jamesfredley).

Head commit for run:
61b7d3c0ada1b9099fab04bac2587c7d85f1deec / James Fredley 
<[email protected]>
fix(grails-gsp): eliminate race condition in FormTagLib2Tests.testDatePickerTag

The testDatePickerTag helper used by every testDatePickerTagWith*Precision()
case rendered the date-picker HTML first, then constructed a fresh
GregorianCalendar afterwards to derive the expected select-field values.
When the two calls fell on opposite sides of a minute (or hour/day/year)
boundary the picker output and the calendar disagreed, producing a flaky
assertion such as:

  FormTagLib2Tests > testDatePickerTagWithMinutePrecision()
  expected: <true> but was: <false>
    at assertSelectFieldPresentWithSelectedValue (FormTagLib2Tests:307)
    at validateSelectedMinuteValue (FormTagLib2Tests:297)
    at testDatePickerTag (FormTagLib2Tests:237)

Observed in CI on Build Grails-Core (windows-latest, 25) where the slower
runner crossed a minute boundary between the two calls.

Capture the calendar up-front and, when the test passes a null date,
forward calendar.getTime() to the picker so both sides agree on a single
instant. Behaviour for explicit Date arguments is unchanged.

Verified:

  ./gradlew :grails-gsp:test --tests org.grails.web.taglib.FormTagLib2Tests 
--rerun-tasks
    -> 11 tests, all passing (including testDatePickerTagWithMinutePrecision)

Assisted-by: claude-code:claude-opus-4-7

Report URL: https://github.com/apache/grails-core/actions/runs/25179507774

With regards,
GitHub Actions via GitBox

Reply via email to