jdaugherty commented on code in PR #15339:
URL: https://github.com/apache/grails-core/pull/15339#discussion_r3179421549
##########
grails-forge/grails-forge-core/src/main/java/org/grails/forge/feature/database/TestContainers.java:
##########
@@ -83,7 +83,10 @@ public void apply(GeneratorContext generatorContext) {
}
if (generatorContext.isFeaturePresent(MongoFeature.class) ||
generatorContext.isFeaturePresent(MongoGorm.class)) {
-
generatorContext.addDependency(testContainerTestDependency("mongodb"));
+ generatorContext.addDependency(Dependency.builder()
+ .groupId("org.apache.grails.testing")
Review Comment:
Hi @sanjana2505006 the original request was to make a forge feature that
when selected, would add the test function to the generated app. This change
instead adds that feature automatically when mongodb is selected. We need to
revisit this PR to create a regular feature (non-default) that can be selected
only when mongodb is selected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
