jdaugherty commented on code in PR #15568:
URL: https://github.com/apache/grails-core/pull/15568#discussion_r3223151267
##########
grails-data-hibernate7/core/src/test/groovy/org/grails/orm/hibernate/connections/HibernateConnectionSourceSettingsSpec.groovy:
##########
@@ -33,14 +32,14 @@ class HibernateConnectionSourceSettingsSpec extends
Specification {
when:"The configuration is built"
Map config = [
'dataSource.dbCreate': 'update',
- 'dataSource.dialect': Oracle8iDialect.name,
+ 'dataSource.dialect': H2Dialect.name,
'dataSource.formatSql': 'true',
'hibernate.flush.mode': 'commit',
'hibernate.cache.queries': 'true',
'hibernate.hbm2ddl.auto': 'create',
'hibernate.cache':['region.factory_class':'org.hibernate.cache.ehcache.SingletonEhCacheRegionFactory'],
Review Comment:
This is a unit test, but it was configuring the cache - it's still using the
older cache factory. This should be
`org.hibernate.cache.jcache.internal.JCacheRegionFactory` now - what is this
test still testing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
