jdaugherty commented on PR #15568:
URL: https://github.com/apache/grails-core/pull/15568#issuecomment-4471407680
I believe I have explanations or resolutions to all of my critical issues.
These 3 remain:
1. grails-gsp/.../GroovyPagesServlet.java
A change to the thread context class loader flagged by PMD. I think it's
probably fine but this has caused issues historically. I'll leave the
conversation unresolved in case @davydotcom wants to respond.
2. grails-datastore-core/.../ConnectionSource.java
The default datastore name was changed. I am OK with it but I'd like to
understand the rationale — why was it necessary to change the default?
3. I left a TODO in the mongo doc build since we can't include hibernate5 &
hibernate7. Hopefully @jamesfredley has some feedback here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
