jdaugherty commented on code in PR #15382:
URL: https://github.com/apache/grails-core/pull/15382#discussion_r3255388557
##########
grails-gradle/plugins/src/main/groovy/org/grails/gradle/plugin/core/GrailsGradlePlugin.groovy:
##########
@@ -227,10 +227,17 @@ class GrailsGradlePlugin implements Plugin<Project> {
// Configure indy and log status after evaluation so user's grails { }
block has been applied
GrailsExtension grailsExtension =
project.extensions.findByType(GrailsExtension)
project.afterEvaluate {
- boolean indyEnabled = grailsExtension?.indy?.getOrElse(false) ?:
false
+ boolean indyEnabled = grailsExtension.indy?.getOrElse(false) ?:
false
+ Boolean preserveParameterNames =
grailsExtension.preserveParameterNames?.getOrNull()
Review Comment:
You are correctly. I expanded the test coverage and documented the
behaviors of `.provider { null }` vs `= null`
##########
grails-gradle/plugins/src/main/groovy/org/grails/gradle/plugin/core/GrailsGradlePlugin.groovy:
##########
@@ -227,10 +227,17 @@ class GrailsGradlePlugin implements Plugin<Project> {
// Configure indy and log status after evaluation so user's grails { }
block has been applied
GrailsExtension grailsExtension =
project.extensions.findByType(GrailsExtension)
project.afterEvaluate {
- boolean indyEnabled = grailsExtension?.indy?.getOrElse(false) ?:
false
+ boolean indyEnabled = grailsExtension.indy?.getOrElse(false) ?:
false
+ Boolean preserveParameterNames =
grailsExtension.preserveParameterNames?.getOrNull()
+
project.tasks.withType(GroovyCompile).configureEach {
GroovyCompile c ->
c.groovyOptions.optimizationOptions.indy = indyEnabled
+
+ if (preserveParameterNames != null) {
Review Comment:
I added a test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
