matrei commented on code in PR #15568:
URL: https://github.com/apache/grails-core/pull/15568#discussion_r3265618526
##########
grails-data-hibernate5/core/src/main/groovy/org/grails/orm/hibernate/query/AbstractHibernateCriterionAdapter.java:
##########
@@ -385,6 +385,16 @@ public Criterion
toHibernateCriterion(AbstractHibernateQuery hibernateQuery, Que
}
});
+ criterionAdaptors.put(Query.SizeNotEquals.class, new
CriterionAdaptor<Query.SizeNotEquals>() {
Review Comment:
> I believe it was rewritten to ensure it's testing the same APIs that both
of them implement. There was a gap in hibernate 5. I'm actually against
removing this one as it's a legitmate bug in hibernate 5
I don't think we should change the tests. If there are differences between
H5 and H7, we should document them with `@Requires`.
If there is a bug in H5, we should add a ticket/pr targeted against the
appropriate release branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
