testlens-app[bot] commented on PR #15558: URL: https://github.com/apache/grails-core/pull/15558#issuecomment-4512969063
## 🚨 TestLens detected 2 failed tests 🚨 Here is what you can do: 1) Inspect the test failures carefully. 2) If you are convinced that some of the tests are flaky, you can mute them below. 3) Finally, trigger a rerun by checking the rerun checkbox. ### Test Summary | Check | Project/Task | Test | Runs | |---|---|---|---| | [CI / Build Grails-Core \(macos-latest, 21\)](https://github.com/apache/grails-core/actions/runs/26253672422/job/77270969747?pr=15558) | :grails-testing-support-http-client:test | TestHttpResponseSpec > xml secure default still allows inline doctype declarations with internal entities | ❌ | | [CI / Build Grails-Core \(macos-latest, 21\)](https://github.com/apache/grails-core/actions/runs/26253672422/job/77270969747?pr=15558) | :grails-testing-support-http-client:test | TestHttpResponseSpec > xml uses a secure default slurper that does not resolve external entities | ❌ | 🏷️ Commit: 93fdd600f6de347a317c5f6973b15340753db958 ▶️ Tests: 263 executed 🟡 Checks: 0/26 completed ### Test Failures <details> <summary><strong>TestHttpResponseSpec > xml secure default still allows inline doctype declarations with internal entities</strong> (:grails-testing-support-http-client:test in <a href="https://github.com/apache/grails-core/actions/runs/26253672422/job/77270969747?pr=15558";>CI / Build Grails-Core (macos-latest, 21)</a>)</summary> ``` Condition failed with Exception: response.xml().text() == 'safe' | | | org.xml.sax.SAXParseException; lineNumber: 1; columnNumber: 10; DOCTYPE is disallowed when the feature "http://apache.org/xml/features/disallow-doctype-decl"; set to true. | at java.xml/com.sun.org.apache.xerces.internal.parsers.AbstractSAXParser.parse(AbstractSAXParser.java:1251) | at java.xml/com.sun.org.apache.xerces.internal.jaxp.SAXParserImpl$JAXPSAXParser.parse(SAXParserImpl.java:637) | at groovy.xml.XmlSlurper.parse(XmlSlurper.java:340) | at groovy.xml.XmlSlurper.parse(XmlSlurper.java:396) | at groovy.xml.XmlSlurper.parseText(XmlSlurper.java:435) | at org.apache.grails.testing.http.client.TestHttpResponse.xml(TestHttpResponse.groovy:159) | at org.apache.grails.testing.http.client.TestHttpResponseSpec.xml secure default still allows inline doctype declarations with internal entities(TestHttpResponseSpec.groovy:231) <org.apache.grails.testing.http.client.TestHttpResponse@489bc8fd delegate=inaccessible jsonSlurperConfig=inaccessible xmlSlurperConfig=inaccessible> at org.apache.grails.testing.http.client.TestHttpResponseSpec.xml secure default still allows inline doctype declarations with internal entities(TestHttpResponseSpec.groovy:231) Caused by: org.xml.sax.SAXParseException; lineNumber: 1; columnNumber: 10; DOCTYPE is disallowed when the feature "http://apache.org/xml/features/disallow-doctype-decl"; set to true. at java.xml/com.sun.org.apache.xerces.internal.parsers.AbstractSAXParser.parse(AbstractSAXParser.java:1251) at java.xml/com.sun.org.apache.xerces.internal.jaxp.SAXParserImpl$JAXPSAXParser.parse(SAXParserImpl.java:637) at groovy.xml.XmlSlurper.parse(XmlSlurper.java:340) at groovy.xml.XmlSlurper.parse(XmlSlurper.java:396) at groovy.xml.XmlSlurper.parseText(XmlSlurper.java:435) at org.apache.grails.testing.http.client.TestHttpResponse.xml(TestHttpResponse.groovy:159) ... 1 more ``` </details> <details> <summary><strong>TestHttpResponseSpec > xml uses a secure default slurper that does not resolve external entities</strong> (:grails-testing-support-http-client:test in <a href="https://github.com/apache/grails-core/actions/runs/26253672422/job/77270969747?pr=15558";>CI / Build Grails-Core (macos-latest, 21)</a>)</summary> ``` Condition not satisfied: e.message.contains('External Entity') | | | | | false | DOCTYPE is disallowed when the feature "http://apache.org/xml/features/disallow-doctype-decl"; set to true. org.xml.sax.SAXParseException; lineNumber: 1; columnNumber: 10; DOCTYPE is disallowed when the feature "http://apache.org/xml/features/disallow-doctype-decl"; set to true. at java.xml/com.sun.org.apache.xerces.internal.parsers.AbstractSAXParser.parse(AbstractSAXParser.java:1251) at java.xml/com.sun.org.apache.xerces.internal.jaxp.SAXParserImpl$JAXPSAXParser.parse(SAXParserImpl.java:637) at groovy.xml.XmlSlurper.parse(XmlSlurper.java:340) at groovy.xml.XmlSlurper.parse(XmlSlurper.java:396) at groovy.xml.XmlSlurper.parseText(XmlSlurper.java:435) at org.apache.grails.testing.http.client.TestHttpResponse.xml(TestHttpResponse.groovy:159) at org.apache.grails.testing.http.client.TestHttpResponseSpec.$spock_feature_0_8(TestHttpResponseSpec.groovy:213) at org.apache.grails.testing.http.client.TestHttpResponseSpec.xml uses a secure default slurper that does not resolve external entities(TestHttpResponseSpec.groovy:217) ``` </details> ### Muted Tests > [!NOTE] > Checks are currently running using the configuration below. Select tests to mute in this pull request: 🔲 TestHttpResponseSpec > xml secure default still allows inline doctype declarations with internal entities <!-- uniqueId=[engine:spock]/[spec:org.apache.grails.testing.http.client.TestHttpResponseSpec]/[feature:$spock_feature_0_9] --> 🔲 TestHttpResponseSpec > xml uses a secure default slurper that does not resolve external entities <!-- uniqueId=[engine:spock]/[spec:org.apache.grails.testing.http.client.TestHttpResponseSpec]/[feature:$spock_feature_0_8] --> Reuse successful test results: 🔲 ♻️ Only rerun the tests that failed or were muted before Click the checkbox to trigger a rerun: 🔲 **Rerun jobs** --- _Learn more about TestLens at [testlens.app](https://testlens.app)._ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
