jamesfredley commented on PR #15686: URL: https://github.com/apache/grails-core/pull/15686#issuecomment-4577145279
## Code-style (Checkstyle) status: forge backlog left red on purpose Separate from the PMD/SpotBugs report above, this stack also turns on **Checkstyle gating for the `grails-forge` modules** (the code-style config + `grails-forge/gradle/code-style-config.gradle` are part of this branch's diff vs `8.0.x`). The Core and Gradle-plugin code-style jobs are clean and pass; only **Forge Projects** fails. I briefly made the code-style jobs report-only for consistency with the analysis jobs, then reverted it - we are **not** masking style errors. The `Forge Projects` code-style job is intentionally **left red** for now rather than fixed, because it's the same "huge backlog" situation. ### The forge Checkstyle backlog: 1,088 errors across 259 files By module: | Module | Files | Errors | | :--- | ---: | ---: | | grails-forge-core | 165 | 731 | | grails-forge-cli | 41 | 206 | | grails-forge-api | 46 | 134 | | grails-forge-analytics-postgres | 6 | 15 | | grails-forge-web-netty | 1 | 2 | By rule: | Count | Rule | | ---: | :--- | | 566 | ImportOrder | | 206 | UnusedImports | | 200 | EmptyLineSeparator | | 37 | Indentation | | 36 | SingleSpaceSeparator | | 25 | AvoidStarImport | | 17 | WhitespaceAfter | | 1 | SeparatorWrap | ### Note Unlike the PMD/SpotBugs findings, every one of these is a **purely mechanical formatting rule** - no behavior change. The top three (ImportOrder + UnusedImports + EmptyLineSeparator = ~89%) are exactly what an IDE "Optimize Imports" + reformat, or a Spotless/`importOrder` pass, would fix automatically. So this backlog is safe to clear in bulk whenever we choose to - it's just out of scope for this draft right now. > PR #15687 is stacked on this branch and inherits the same code-style jobs / red Forge result. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
