borinquenkid commented on PR #15686:
URL: https://github.com/apache/grails-core/pull/15686#issuecomment-4587104506
Update — Spotless removed from grails-forge (supersedes the Spotless changes
described above)
While clearing the remaining Checkstyle violations, the importOrder +
removeUnusedImports Spotless config turned out to be unable to fully mirror
Checkstyle:
- Spotless's prefix-based importOrder treats grails.* and org.grails.* as
separate groups (inserts a blank line between them), while Checkstyle's regex
merges them into one group (forbids that blank
line). There's no Spotless config that expresses the merged group, so
files importing both (e.g. AddPropertyCommand) were an unsatisfiable conflict —
Spotless and Checkstyle could never both pass.
- Because checkstyleMain depended on spotlessCheck, that conflict (and
pre-existing violations elsewhere) were gated/hidden rather than surfaced.
Resolution: removed the bespoke Spotless config from grails-forge
entirely. Layout is now owned solely by Checkstyle (verification) + the shared
project .idea code-style, which can express the merged
grails group and matches Checkstyle exactly. This puts grails-forge on the
same Checkstyle + CodeNarc model as the root build.
- JDK 25 fix still holds — there's no Java formatter left to hit the
NoSuchMethodError.
- Dropped the checkstyleMain dependsOn spotlessCheck gate; Checkstyle now
runs on all production Java unconditionally.
- Cleared all surfaced violations across grails-forge-core,
grails-forge-api, and grails-forge-cli (whitespace, import order,
annotation-array indentation).
- Left the inert spotless-plugin-gradle buildSrc dependency in place — it
pins a groovy-4-compatible Spotless version over micronaut-gradle-plugins'
older transitive copy; it's no longer applied.
Commit: 4149f44554
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
