matrei commented on code in PR #15710:
URL: https://github.com/apache/grails-core/pull/15710#discussion_r3346443023
##########
grails-forge/grails-forge-core/src/main/java/org/grails/forge/build/gradle/GradleRepository.java:
##########
@@ -66,6 +66,17 @@ static Set<GradleRepository> getDefaultRepositories(String
grailsVersion) {
),
List.of(VersionType.SNAPSHOT)
));
+ repositories.add(new DefaultGradleRepository(
+ repositories.size(),
+ "https://central.sonatype.com/repository/maven-snapshots";,
+ null,
+ List.of(
+ new VersionRegexRepoFilter(
+ "org[.]sitemesh.*", ".*", ".*-SNAPSHOT"
Review Comment:
We don't need to include `-SNAPSHOT` in the regex here as that is explicitly
set by the `VersionType.SNAPSHOT` below. (I know you probably followed suit
here)
##########
grails-profiles/web/profile.yml:
##########
@@ -44,7 +44,7 @@ dependencies:
- scope: implementation
coords: "org.apache.grails:grails-url-mappings"
- scope: implementation
- coords: "org.apache.grails:grails-layout"
+ coords: "org.apache.grails:grails-sitemesh3"
Review Comment:
Shouldn't this be changed in gh-15713?
##########
grails-shell-cli/src/main/groovy/org/grails/cli/profile/commands/CreateAppCommand.groovy:
##########
@@ -517,6 +517,10 @@ class CreateAppCommand extends ArgumentCompletingCommand
implements ProfileRepos
GrailsGradleRepository repository = new
GrailsGradleRepository(url:
'https://repository.apache.org/content/groups/snapshots', snapshotsOnly: true)
repository.includeOnly('org[.]apache[.](grails|groovy).*', '.*',
'.*-SNAPSHOT')
configuredRepositories.add(repository)
+
+ GrailsGradleRepository sitemeshSnapshots = new
GrailsGradleRepository(url:
'https://central.sonatype.com/repository/maven-snapshots', snapshotsOnly: true)
+ sitemeshSnapshots.includeOnly('org[.]sitemesh.*', '.*',
'.*-SNAPSHOT')
Review Comment:
The regex does not have to include `-SNAPSHOT` as `snapshotsOnly: true` is
set above. (I know you probably followed suit here).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
