jdaugherty commented on PR #15467: URL: https://github.com/apache/grails-core/pull/15467#issuecomment-4612916052
I'm a -1 on this until the following is addressed: 1. we reworked the boms so we don't apply both of them. We only ever expect 1 grails bom to be applied. This PR still assumes multiple are applied. 2. we need to have test coverage for the legacy spring gradle plugin 3. we need to ensure the spring boot apps continue to use the spring plugin or we duplicate the apps and test both. We cannot assume that end user spring applications are going to adopt Grails specific gradle plugins 4. we need to adopt the maven-model parsing everywhere we were parsing xml, not just our version extractor for documentation -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
